crail-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PepperJo <...@git.apache.org>
Subject [GitHub] incubator-crail pull request #26: Start script: remove heap size argument
Date Wed, 20 Jun 2018 14:10:15 GMT
Github user PepperJo commented on a diff in the pull request:

    https://github.com/apache/incubator-crail/pull/26#discussion_r196793997
  
    --- Diff: bin/crail ---
    @@ -70,4 +70,4 @@ fi
     export CLASSPATH="$bin"/../jars/*:"$bin"/../conf:.
     export LD_LIBRARY_PATH="$bin/../lib:$LD_LIBRARY_PATH"
     
    -exec "$JAVA" -Dproc_$COMMAND -XX:MaxDirectMemorySize=64G -Dsun.nio.PageAlignDirectMemory=true
-Xmn16G $CLASS "$@"
    +exec "$JAVA" -Dproc_$COMMAND -Dsun.nio.PageAlignDirectMemory=true $CLASS "$@"
    --- End diff --
    
    MaxDirectMemorySize is definitely not needed it just sets a limit for direct memory otherwise
it will take as much as there is heap space. The Xmx/n is a problem for large clusters but
what default value should we set? I can add a crail-env.sh to set these values, but by default
I still would not set anything. I can add a warning in the script that suggests setting these
values (given the user has lots of memory).


---

Mime
View raw message