Mailing-List: contact user-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@couchdb.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Subject: Encountered all_dbs_active with compaction daemon on trunk
From: Mike Leddy <mike@loop.com.br>
To: user <user@couchdb.apache.org>
Date: Mon, 05 Sep 2011 14:46:14 -0300
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Message-ID: <1315244775.4259.22.camel@mike.loop.com.br>
Mime-Version: 1.0

Hi,

I decided to test out the latest trunk on one of my nodes with some
2,500 databases. On activating the compaction daemon it became apparent
that some databases were being opened but not closed. 

Looking at the debug logs it became clear that when a database did not
need to be compacted it was remaining open (confirmed with lsof).

I made a small one line patch which seems to have resolved the problem:

--- a/src/couchdb/couch_compaction_daemon.erl
+++ b/src/couchdb/couch_compaction_daemon.erl
@@ -185,6 +185,7 @@ maybe_compact_db(DbName, Config) ->
                 end
             end;
         false ->
+            couch_db:close(Db),
             maybe_compact_views(DbName, DDocNames, Config)
         end;
     _ ->

This makes sure that when can_db_compact returns false that
couch_db:close is called. [I have to admit it seems strange 
to me to call couch_db:close in four different places to clean
up the the one couch_db:open_int but my erlang coding skills
are weak.]

Regards,

Mike