couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Vatamaniuc <vatam...@gmail.com>
Subject Re: Following our Review-Then-Commit process
Date Tue, 04 Apr 2017 02:23:51 GMT
On 04/03/2017 05:17 PM, Joan Touzet wrote:
> All,
>
> I wanted to express a concern with my CouchDB PMC hat on.
>
> There is some great work being merged by Cloudant here. But I'm not
> seeing the Review-Then-Commit pattern being followed in a significant
> number of these PRs coming through to any of our repos.
>
> Take as an example this one, which is one of 4 related PRs to merge
> replicator scheduling work. None of these 4 PRs shows an independent +1
> posted to the comment thread, or even a token +1 by a fellow Cloudant
> committer.

A branch was deleted because because monorepo work made it invalid.

Nothing was merged. I think it might be confusing seeing the PR 
auto-close after branch delete and assuming it was because of a merge...?

This is still WIP. There will be new PR and a mailing list announcement 
soon.

-Nick



Mime
View raw message