couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton issue #883: Navbar refactor
Date Fri, 31 Mar 2017 07:07:21 GMT
Github user garrensmith commented on the issue:

    https://github.com/apache/couchdb-fauxton/pull/883
  
    I'm happy with that
    
    All misspelling thanks to my iPhone.
    ________________________________
    From: Ryan Millay <notifications@github.com>
    Sent: Thursday, March 30, 2017 10:41:00 PM
    To: apache/couchdb-fauxton
    Cc: garren smith; Comment
    Subject: Re: [apache/couchdb-fauxton] Navbar refactor (#883)
    
    
    @millayr commented on this pull request.
    
    ________________________________
    
    In app/addons/fauxton/navigation/stores.js<https://github.com/apache/couchdb-fauxton/pull/883#discussion_r109031856>:
    
    > @@ -94,8 +107,7 @@ Stores.NavBarStore = FauxtonAPI.Store.extend({
       },
    
       toggleMenu () {
    -    app.utils.localStorageSet(FauxtonAPI.constants.LOCAL_STORAGE.SIDEBAR_MINIMIZED,
    -                              !this.isMinimized());
    +    this._isMinimized = !this._isMinimized;
    
    
    I think I'd prefer to leave this as-is. The new logic forces the sidebar to be minimized
by default, showing users that they have much more screen real estate to work with, which
is inline with the user research and feedback.
    
    —
    You are receiving this because you commented.
    Reply to this email directly, view it on GitHub<https://github.com/apache/couchdb-fauxton/pull/883#discussion_r109031856>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/AAK9AkXB8ALnpNUsstRKQbsywKmcNWZHks5rrBNcgaJpZM4Mm_i->.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message