couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request #883: Navbar refactor
Date Tue, 28 Mar 2017 07:52:14 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108353902
  
    --- Diff: app/addons/fauxton/navigation/components/NavBar.js ---
    @@ -0,0 +1,107 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +import React, { Component } from 'react';
    +
    +import Footer from './Footer';
    +import Burger from './Burger';
    +import NavLink from './NavLink';
    +import Brand from './Brand';
    +import LogoutButton from './LogoutButton';
    +import LoginButton from './LoginButton';
    +
    +import Actions from "../actions";
    +
    +import classNames from 'classnames';
    +import _ from 'lodash';
    +
    +class NavBar extends Component {
    +
    +  createLinks (links) {
    +    const { activeLink, isMinimized } = this.props;
    +
    +    return _.map(links, (link, i) => {
    --- End diff --
    
    Can you rather do `links.map`. We don't need to use lodash for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message