couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From millayr <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...
Date Mon, 13 Mar 2017 19:33:18 GMT
Github user millayr commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105750432
  
    --- Diff: app/addons/replication/stores.js ---
    @@ -77,6 +110,23 @@ const ReplicationStore = FauxtonAPI.Store.extend({
         this._activitySort = sort;
       },
     
    +  isReplicateInfoLoading () {
    +    return this._fetchingReplicateInfo;
    +  },
    +
    +  getReplicateInfo () {
    +    return this._replicateInfo.filter(doc => {
    +      return _.values(doc).filter(item => {
    +        if (!item) {return null;}
    --- End diff --
    
    Minor but can we change this to return `false`?  I feel like it'd be more readable when
considering `filter` keeps/discards items based on boolean values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message