couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davisp <...@git.apache.org>
Subject [GitHub] couchdb-couch-epi pull request: The race condition between provide...
Date Wed, 15 Jul 2015 16:04:18 GMT
Github user davisp commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-epi/pull/4#discussion_r34695307
  
    --- Diff: src/couch_epi_data.erl ---
    @@ -88,7 +88,8 @@ handle_call(stop, _From, State) ->
     handle_call(_Request, _From, State) ->
         {reply, ok, State}.
     
    -handle_cast(init, #state{pending = Pending} = State) ->
    +handle_cast(init, #state{pending = Pending, handle = Handle} = State) ->
    +    couch_epi_module_keeper:maybe_start_keeper(couch_epi_data_gen, Handle),
    --- End diff --
    
    What? The entire point of that API was to prevent exactly this situation. Cause what happens
if we want to run mem3 in a deployment without chttpd at all?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message