Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: mikewallace1979 <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-11-couchdb-couch-replicator@git.apache.org>
In-Reply-To: <git-pr-11-couchdb-couch-replicator@git.apache.org>
Subject: [GitHub] couchdb-couch-replicator pull request: 2707 merge couch
 replicator...
Content-Type: text/plain
Message-Id: <20150602174543.1D7EEE022E@git1-us-west.apache.org>
Date: Tue,  2 Jun 2015 17:45:43 +0000 (UTC)

Github user mikewallace1979 commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31549934
  
    --- Diff: src/couch_replicator_manager.erl ---
    @@ -403,13 +442,10 @@ process_update(State, DbName, {Change}) ->
             end
         end.
     
    -owner(<<"shards/", _/binary>> = DbName, DocId) ->
    -    Live = [node()|nodes()],
    +owner(<<"shards/", _/binary>> = DbName, DocId, Live) ->
         Nodes = lists:sort([N || #shard{node=N} <- mem3:shards(mem3:dbname(DbName), DocId),
     			     lists:member(N, Live)]),
    -    node() =:= hd(mem3_util:rotate_list({DbName, DocId}, Nodes));
    -owner(_DbName, _DocId) ->
    --- End diff --
    
    Darn. So would the right thing be to return `node()` now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---