Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: kxepal <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-11-couchdb-couch-replicator@git.apache.org>
In-Reply-To: <git-pr-11-couchdb-couch-replicator@git.apache.org>
Subject: [GitHub] couchdb-couch-replicator pull request: 2707 merge couch
 replicator...
Content-Type: text/plain
Message-Id: <20150602174450.AC8BFE022E@git1-us-west.apache.org>
Date: Tue,  2 Jun 2015 17:44:50 +0000 (UTC)

Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31549841
  
    --- Diff: src/couch_replicator_manager.erl ---
    @@ -451,7 +487,14 @@ maybe_start_replication(State, DbName, DocId, RepDoc) ->
             true = ets:insert(?DOC_TO_REP, {{DbName, DocId}, RepId}),
             couch_log:notice("Attempting to start replication `~s` (document `~s`).",
                 [pp_rep_id(RepId), DocId]),
    -        Pid = spawn_link(fun() -> start_replication(Rep, 0) end),
    +        StartDelaySecs = erlang:max(0, list_to_integer(
    +            config:get("replicator", "start_delay", "10"))),
    --- End diff --
    
    There is nicer helper [config:get_integer(Key, Value, Default)](https://github.com/apache/couchdb-config/blob/master/src/config.erl#L60-L66).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---