couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewallace1979 <...@git.apache.org>
Subject [GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...
Date Wed, 03 Jun 2015 10:08:55 GMT
Github user mikewallace1979 commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31609446
  
    --- Diff: src/couch_replicator_api_wrap.erl ---
    @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) ->
                         ok
                     end)
             end,
    -        send_req(Db, [{method, head}],
    -            fun(200, _, _) ->
    -                {ok, Db};
    +        send_req(Db, [{method, get}],
    +            fun(200, _, {Props}) ->
    +                case get_value(<<"update_seq">>, Props) of
    --- End diff --
    
    I'm not quite sure I'm following this. The current PR code is using the presence of `update_seq`
as a proxy for "this is a response from an actual database" (as opposed to a response from
a resource which returns a 200 but isn't a database at all).
    
    @kxepal Is your suggestion that we should also check for the presence of `instance_start_time`
in order to detect the case where a resource happens to provide an `update_seq` but no `instance_start_time`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message