couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rnewson <...@git.apache.org>
Subject [GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...
Date Tue, 02 Jun 2015 20:56:09 GMT
Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31570119
  
    --- Diff: src/couch_replicator_api_wrap.erl ---
    @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) ->
                         ok
                     end)
             end,
    -        send_req(Db, [{method, head}],
    -            fun(200, _, _) ->
    -                {ok, Db};
    +        send_req(Db, [{method, get}],
    +            fun(200, _, {Props}) ->
    +                case get_value(<<"update_seq">>, Props) of
    --- End diff --
    
    I can't make sense of that. This check is refining the check from 'did I get a 200' to
'did I get a 200 with a json body with an update_seq in it' in order to crash if source or
target is not couchdb. It has nothing to do with whether checkpoints would work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message