couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewallace1979 <...@git.apache.org>
Subject [GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...
Date Tue, 02 Jun 2015 17:36:37 GMT
Github user mikewallace1979 commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31548914
  
    --- Diff: src/couch_replicator_manager.erl ---
    @@ -403,13 +442,10 @@ process_update(State, DbName, {Change}) ->
             end
         end.
     
    -owner(<<"shards/", _/binary>> = DbName, DocId) ->
    -    Live = [node()|nodes()],
    +owner(<<"shards/", _/binary>> = DbName, DocId, Live) ->
         Nodes = lists:sort([N || #shard{node=N} <- mem3:shards(mem3:dbname(DbName), DocId),
     			     lists:member(N, Live)]),
    -    node() =:= hd(mem3_util:rotate_list({DbName, DocId}, Nodes));
    -owner(_DbName, _DocId) ->
    --- End diff --
    
    @rnewson @davisp I'm a little concerned by the fact that the second function clause for
owner/2 disappears - it doesn't exist over in cloudant/couch_replicator and I wasn't quite
sure what the right thing to do here was, as I don't have the context of why the second clause
existed here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message