Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5009518694 for ; Thu, 28 May 2015 16:23:46 +0000 (UTC) Received: (qmail 77683 invoked by uid 500); 28 May 2015 16:23:46 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 77622 invoked by uid 500); 28 May 2015 16:23:46 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 77611 invoked by uid 99); 28 May 2015 16:23:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2015 16:23:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6053EE10BE; Thu, 28 May 2015 16:23:45 +0000 (UTC) From: benkeen To: dev@couchdb.apache.org Reply-To: dev@couchdb.apache.org References: In-Reply-To: Subject: [GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p... Content-Type: text/plain Message-Id: <20150528162345.6053EE10BE@git1-us-west.apache.org> Date: Thu, 28 May 2015 16:23:45 +0000 (UTC) Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-106462115 @wadsashika that's a fair point. But I wouldn't worry: I don't think any of the points I make above are actual bugs, just stylistic. And none are particularly egregious, I'm just giving you a hard time because you're new and hey, that's my job here. ;) Internally, we mix and match who reviews who's code, and everyone has their own viewpoints. That's the awesome part about code reviews: you always get feedback that you won't have thought of, and everyone's different. So you're right, some of these things are already in the code but I wouldn't worry too much about it. We work as a group. And of course: you're always welcome to disagree! If Michelle or Robert were here in Vancouver, I'm pretty sure I'd have demanded settling an argument by an arm wrestle or something. @michellephung, @robertkowalski that's a fair point Robert. But yeah I'm not averse keeping the widget separate for the moment. Once it's a little more settled we could look at extracting shared code if there are big chunks. The parts I looked at looked like just pieces here and there, which isn't so bad. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---