Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: benkeen <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-434-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-434-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as
 main p...
Content-Type: text/plain
Message-Id: <20150527192849.94AFADFFF0@git1-us-west.apache.org>
Date: Wed, 27 May 2015 19:28:49 +0000 (UTC)

Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31170976
  
    --- Diff: app/addons/dashboard/stores.js ---
    @@ -0,0 +1,169 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +define([
    +  'app',
    +  'api',
    +  'addons/activetasks/actiontypes'
    +], function (app, FauxtonAPI, ActionTypes) {
    +
    +  var DashboardStore = FauxtonAPI.Store.extend({
    +
    +    init: function (collectionTable, backboneCollection) {
    +      this._prevSortbyHeader = 'started_on';
    +      this._headerIsAscending = true;
    +      this._selectedRadio = 'All Tasks';
    +      this._sortByHeader = 'started_on';
    +      this._searchTerm = '';
    +      this._collection = collectionTable;
    +      this._pollingIntervalSeconds = 5;
    +      this.sortCollectionByColumnHeader(this._sortByHeader);
    +      this._backboneCollection = backboneCollection;
    +    },
    +
    +    getSelectedRadio: function () {
    +      return this._selectedRadio;
    +    },
    +
    +    setSelectedRadio: function (selectedRadio) {
    +      this._selectedRadio = selectedRadio;
    +    },
    +
    +    getPollingInterval: function () {
    +      return this._pollingIntervalSeconds;
    +    },
    +
    +    setPollingInterval: function (pollingInterval) {
    +      this._pollingIntervalSeconds = pollingInterval;
    +    },
    +
    +    setPolling: function () {
    +      clearInterval(this.getIntervalID());
    +      var id = setInterval(function () {
    +        this._backboneCollection.pollingFetch();
    +        this.setCollection(this._backboneCollection.table);
    +        this.sortCollectionByColumnHeader(this._prevSortbyHeader, false);
    +        this.triggerChange();
    +      }.bind(this), this.getPollingInterval() * 1000);
    +
    +      this.setIntervalID(id);
    --- End diff --
    
    Meh! I'd drop this method, drop `id` and just set `this._intervalID` to the result of the setInterval method (unless you think it's needed for tests?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---