Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B10E718EDC for ; Tue, 26 May 2015 15:30:42 +0000 (UTC) Received: (qmail 4285 invoked by uid 500); 26 May 2015 15:30:42 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 4223 invoked by uid 500); 26 May 2015 15:30:42 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 4212 invoked by uid 99); 26 May 2015 15:30:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 May 2015 15:30:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E4C7CDFF5E; Tue, 26 May 2015 15:30:41 +0000 (UTC) From: kxepal To: dev@couchdb.apache.org Reply-To: dev@couchdb.apache.org References: In-Reply-To: Subject: [GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u... Content-Type: text/plain Message-Id: <20150526153041.E4C7CDFF5E@git1-us-west.apache.org> Date: Tue, 26 May 2015 15:30:41 +0000 (UTC) Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/55#discussion_r31046410 --- Diff: src/couch_httpd.erl --- @@ -30,6 +30,7 @@ -export([send_json/2,send_json/3,send_json/4,last_chunk/1,parse_multipart_request/3]). -export([accepted_encodings/1,handle_request_int/5,validate_referer/1,validate_ctype/2]). -export([http_1_0_keep_alive/2]). +-export([add_default_headers_if_needed/2, add_header_if_needed/2]). --- End diff -- If these functions are internal, no need to pollute export API. eunit tests could be defined inline at the end of the module via check against TEST definition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---