couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...
Date Thu, 28 May 2015 16:23:45 GMT
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-106462115
  
    @wadsashika that's a fair point. But I wouldn't worry: I don't think any of the points
I make above are actual bugs, just stylistic. And none are particularly egregious, I'm just
giving you a hard time because you're new and hey, that's my job here. ;) 
     
    Internally, we mix and match who reviews who's code, and everyone has their own viewpoints.
That's the awesome part about code reviews: you always get feedback that you won't have thought
of, and everyone's different. So you're right, some of these things are already in the code
but I wouldn't worry too much about it. We work as a group. And of course: you're always welcome
to disagree! If Michelle or Robert were here in Vancouver, I'm pretty sure I'd have demanded
settling an argument by an arm wrestle or something.
    
    @michellephung, @robertkowalski that's a fair point Robert. But yeah I'm not averse keeping
the widget separate for the moment. Once it's a little more settled we could look at extracting
shared code if there are big chunks. The parts I looked at looked like just pieces here and
there, which isn't so bad. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message