couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Databases component fix
Date Wed, 27 May 2015 14:32:48 GMT
Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/440#discussion_r31139219
  
    --- Diff: tasks/fauxton.js ---
    @@ -116,6 +116,12 @@ module.exports = function (grunt) {
         var fileSrc = grunt.option('file') || data.files.src;
         var testFiles =  grunt.file.expand(fileSrc);
     
    +    // filter out any tests that aren't found in the /app/ folder. For scripts that are
extending Fauxton, we still
    +    // know that all addons will have been copied into /app. This prevent tests being
ran twice
    +    testFiles = _.filter(testFiles, function (filePath) {
    +      return /\/app\//.test(filePath);
    +    });
    +
    --- End diff --
    
    The duplicates were actually relative links in `dashboard/`, not dist; checking for `app/`
(i.e. a folder in Fauxton) is the only appropriate way, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message