couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Detect if we run on a backdoor port
Date Thu, 07 May 2015 12:38:33 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/400#discussion_r29847412
  
    --- Diff: app/app.js ---
    @@ -126,7 +126,30 @@ function (app, $, _, Backbone, Bootstrap, Helpers, Utils, FauxtonAPI,
Couchdb) {
               type: 'REMOVE_NAVBAR_LINK',
               link: link
           });
    +    },
    +
    +    isRunningOnBackdoorPort: function () {
    --- End diff --
    
    I think the name is too broad. If...when.../_config will be available on cluster interface
it will be easy to break all the logic behind that name. 
    
    I would suggest to use some specific like "isConfigAvailable" to control features availability
per resource basis or use some cluster-only resource like `_membership` or `_cluster_setup`
e.g. those that only makes a sense for cluster interface. 
    
    Alternatively, you may figure if you're on cluster or not from `GET /` request - cluster
has no uuid in response, but that's may be also temporary solution.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message