Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: robertkowalski <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-393-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-393-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: Verify install page converted
 to Rea...
Content-Type: text/plain
Message-Id: <20150423100902.2FC06E00DE@git1-us-west.apache.org>
Date: Thu, 23 Apr 2015 10:09:02 +0000 (UTC)

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/393#discussion_r28950994
  
    --- Diff: app/addons/verifyinstall/stores.js ---
    @@ -0,0 +1,101 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +define([
    +  'api',
    +  'addons/verifyinstall/constants',
    +  'addons/verifyinstall/actiontypes'
    +],
    +
    +function (FauxtonAPI, Constants, ActionTypes) {
    +
    +  var VerifyInstallStore = FauxtonAPI.Store.extend({
    +    initialize: function () {
    +      this.reset();
    +    },
    +
    +    reset: function () {
    +      this._isVerifying = false;
    +
    +      // reset all the tests
    +      this._tests = {};
    +      var keys = ['CREATE_DATABASE', 'CREATE_DOCUMENT', 'UPDATE_DOCUMENT', 'DELETE_DOCUMENT', 'CREATE_VIEW', 'REPLICATION'];
    +      _.each(keys, function (key) {
    +        this._tests[Constants.TESTS[key]] = { complete: false };
    +      }, this);
    +    },
    +
    +    startVerification: function () {
    +      this._isVerifying = true;
    +    },
    +
    +    stopVerification: function () {
    +      this._isVerifying = false;
    +    },
    +
    +    checkIsVerifying: function () {
    +      return this._isVerifying;
    +    },
    +
    +    updateTestStatus: function (test, success) {
    +
    +      // shouldn't ever occur since we're using constants for the test names
    +      if (!_.has(this._tests, test)) {
    +        console.error("Invalid test name passed to updateTestStatus()");
    --- End diff --
    
    in that case i would just do:
    
    ```js
    throw new Error('Invalid test name passed to updateTestStatus()');
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---