Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: michellephung <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-388-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-388-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: Test for error handling in
 Active Ta...
Content-Type: text/plain
Message-Id: <20150417201010.C26A9DFF8A@git1-us-west.apache.org>
Date: Fri, 17 Apr 2015 20:10:10 +0000 (UTC)

Github user michellephung commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/388#discussion_r28626153
  
    --- Diff: app/addons/activetasks/tests/activetasks.componentsSpec.react.jsx ---
    @@ -70,6 +70,14 @@ define([
             window.confirm.restore && window.confirm.restore();
           });
     
    +
    +      it('it displays a message instead of an empty table, if there are undefined active tasks', function () {
    +        spy = sinon.spy(Actions, 'setCollection');
    --- End diff --
    
    :/ i'm not really asserting that the spy is called, that's not what i'm testing for. but if i leave the spy uninitialized, the afterEach function calls spy.restore, and errors at that point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---