couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Verify install page converted to Rea...
Date Wed, 22 Apr 2015 22:52:34 GMT
GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/393

    Verify install page converted to React

    This converts the Verify Install page to React.
    
    @robertkowalski, the one thing I had trouble with was writing a decent test for `actions.startVerification()`.
I couldn't override the model that does all the async tests to the server. So instead, this
relies on the  other store, React + existing nightwatch tests confirming the functionality.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton verify-install-react

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #393
    
----
commit a881b90a9450e6c8c240af18561a9134b4ebac67
Author: Ben Keen <ben.keen@gmail.com>
Date:   2015-04-20T23:47:38Z

    Initial pass; converted to React

commit e8e4e33660d0cd2818b15755b982d4f22070c1aa
Author: Ben Keen <ben.keen@gmail.com>
Date:   2015-04-22T22:48:54Z

    tests added

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message