couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Allow customization of view loading ...
Date Wed, 01 Apr 2015 20:37:24 GMT
GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/354

    Allow customization of view loading styles

    By default, the core Fauxton code inserts a spinner for each view
    while it's loading. This can be removed via the disableLoader param
    but not customized. This PR lets you define an optional
    `loaderStyles` property on your view to override the styles. The
    use-case here is to provide a light-coloured loader on the dark-
    background Doc Editor page.
    
    I investigated using the new React spinner, but ran into problems
    targeting views that weren't loaded yet in the page load lifecycle.
    This seemed an elegant solution that tapped into what we already
    had.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton custom-loader-styles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #354
    
----
commit 225b44a34c9a4f95225c2355531480ba581e4c93
Author: Ben Keen <ben.keen@gmail.com>
Date:   2015-04-01T20:33:35Z

    Allow customization of view loading styles
    
    By default, the core Fauxton code inserts a spinner for each view
    while it's loading. This can be removed via the disableLoader param
    but not customized. This PR lets you define an optional
    `loaderStyles` property on your view to override the styles. The
    use-case here is to provide a light-coloured loader on the dark-
    background Doc Editor page.
    
    I investigated using the new React spinner, but ran into problems
    targeting views that weren't loaded yet in the page load lifecycle.
    This seemed an elegant solution that tapped into what we already
    had.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message