couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dholth <...@git.apache.org>
Subject [GitHub] couchdb-couch pull request: rebased _bulk_get patch
Date Tue, 21 Apr 2015 14:06:04 GMT
Github user dholth commented on the pull request:

    https://github.com/apache/couchdb-couch/pull/18#issuecomment-94807050
  
    The principle behind my _bulk_get is that it is *exactly* lots of GET
    returned in an array, the first implementation was even written as a lua
    intermediary between nginx and CouchDB.
    
    This "exactly GET" property makes _bulk_get easier to document and
    understand. All other implementations seemed to want to remove some of
    the weird GET options that no one understands.
    
    For a 404, the JSON response is:
    
    {"error":"not_found","reason":"missing"}
    
    So _bulk_get would return exactly that and maybe add an id field, or you
    might have to remember the order of the original request.
    
    [ [{"_id": "foo", "_rev": "1-967a00dff5e02add41819138abb3284d"}],
    [{"error": "not_found", "_id": "bar", "reason": "missing"}] ]
    
    I checked, and unfortunately my _bulk_get appears to fail entirely if an
    element is not found.
    
    I'm not sure about the array of arrays. Does GET sometimes return an
    array, and sometimes it does not?
    
    Thanks!
    
    On Tue, Apr 21, 2015, at 09:22 AM, Alexander Shorin wrote:
    >> However assuming RCouch has users why not do their json. Double check
    >> to see what arguments PouchDB _bulk_get actually uses.
    
    
    > Well, I'm fine to break compatibility, but I wonder for which side I
    > have to do this.
    
    
    > — Reply to this email directly or view it on GitHub[1].
    
    >
    
    
    
    Links:
    
      1. https://github.com/apache/couchdb-couch/pull/18#issuecomment-94792422



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message