couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:
Date Tue, 21 Apr 2015 09:19:14 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/362#discussion_r28761880
  
    --- Diff: app/addons/documents/mango/mango.components.react.jsx ---
    @@ -121,35 +277,39 @@ function (app, FauxtonAPI, React, Stores, Actions, ReactComponents)
{
             return;
           }
     
    -      this.clearNotifications();
    +      this.getMangoEditor().clearNotifications();
     
           Actions.saveQuery({
             database: this.state.database,
    -        queryCode: this.refs.indexQueryEditor.getValue()
    +        queryCode: this.getMangoEditor().getEditorValue()
           });
         }
       });
     
       var Views = {
    -    renderHelpScreen: function (el) {
    +    renderQueryEditor: function (el) {
           React.render(
    -        <HelpScreen title={app.i18n.en_US['mango-help-title']} />,
    +        <MangoQueryEditorController
    +          description={app.i18n.en_US['mango-descripton']}
    +          editorTitle={app.i18n.en_US['mango-title-editor']}
    +          additionalIndexesText={app.i18n.en_US['mango-additional-indexes-heading']}
/>,
             el
           );
         },
    -    removeHelpScreen: function (el) {
    +    removeQueryEditor: function (el) {
           React.unmountComponentAtNode(el);
         },
         renderMangoIndexEditor: function (el) {
    --- End diff --
    
    Can you update all of these render functions to the new supported `setComponent` in the
RouteObjects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message