couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michellephung <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Databases view in react
Date Mon, 20 Apr 2015 23:26:48 GMT
Github user michellephung commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/370#issuecomment-94591639
  
    if you're feeling up to it, some whitespace nits:
    
    in the render functions, 
    1.) there are some html code that have nested tags and create long lines of html, put
each tag on a newline (the nested tags that are short don't need new lines, but for the longer
ones, its easier and faster to review and debug)
    2.) and for very long tags with lots of attributes, put each attribute on a new line,
for example:
    https://github.com/apache/couchdb-fauxton/blob/master/app/addons/documents/index-editor/components.react.jsx#L96
    
    other than adding the key prop, 
    tests look good :)  code logic looks good :)
    
    FWIW, I am plus one after adding the key attribute to those 2 files, and white space changes
are a "nice to have". 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message