couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michellephung <>
Subject [GitHub] couchdb-fauxton pull request: Test for error handling in Active Ta...
Date Fri, 17 Apr 2015 20:10:10 GMT
Github user michellephung commented on a diff in the pull request:
    --- Diff: app/addons/activetasks/tests/activetasks.componentsSpec.react.jsx ---
    @@ -70,6 +70,14 @@ define([
             window.confirm.restore && window.confirm.restore();
    +      it('it displays a message instead of an empty table, if there are undefined active
tasks', function () {
    +        spy = sinon.spy(Actions, 'setCollection');
    --- End diff --
    :/ i'm not really asserting that the spy is called, that's not what i'm testing for. but
if i leave the spy uninitialized, the afterEach function calls spy.restore, and errors at
that point.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message