couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebastianrothbucher <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Databases view in react
Date Thu, 16 Apr 2015 17:45:39 GMT
Github user sebastianrothbucher commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/370#discussion_r28532530
  
    --- Diff: app/addons/fauxton/components.react.jsx ---
    @@ -84,9 +84,129 @@ function (app, FauxtonAPI, React, ZeroClipboard) {
       });
     
     
    +  var Tray = React.createClass({
    +
    +    getInitialState: function () {
    +      return {
    +        show: false
    +      };
    +    },
    +
    +    toggle: function (done) {
    +      if (this.state.show) {
    +        this.hide(done);
    +      } else {
    +        this.show(done);
    +      }
    +    },
    +
    +    componentDidMount: function () {
    +      $('body').on('click.Tray-' + this.props.trayid + "-" + this._rootNodeID, function
(e) {
    --- End diff --
    
    I found a better solution for that one - thanks!
    BTW: while testing I realized that TestUtils.renderIntoDocument drops our container. So
we can get more stable results by just using React.renderComponent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message