couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Databases view in react
Date Thu, 16 Apr 2015 11:10:44 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/370#discussion_r28500914
  
    --- Diff: app/addons/fauxton/components.react.jsx ---
    @@ -84,9 +84,129 @@ function (app, FauxtonAPI, React, ZeroClipboard) {
       });
     
     
    +  var Tray = React.createClass({
    +
    +    getInitialState: function () {
    +      return {
    +        show: false
    +      };
    +    },
    +
    +    toggle: function (done) {
    +      if (this.state.show) {
    +        this.hide(done);
    +      } else {
    +        this.show(done);
    +      }
    +    },
    +
    +    componentDidMount: function () {
    +      $('body').on('click.Tray-' + this.props.trayid + "-" + this._rootNodeID, function
(e) {
    --- End diff --
    
    be careful regarding `this._rootNodeID`, it will break as soon as we update to 0.13:
    
    from: https://facebook.github.io/react/blog/2015/03/10/react-v0.13.html
    
    ```
    Access to most internal properties has been completely removed, including this._pendingState
and this._rootNodeID.
    ```
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message