couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michellephung <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Databases view in react
Date Mon, 13 Apr 2015 19:08:37 GMT
Github user michellephung commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/370#issuecomment-92464693
  
    Hey @sebastianrothbucher,
    
    We are trying not to use jQuery in the React code, because usually there is a good way
to handle an event without it. I don't think this is written anywhere, since we just started
building with React code. Sorry about that, if that was unclear.
    
    However! for the tray/tooltip, it's okay to use jQuery, since there's not another way
to capture a `$('body').onclick` event or init the tooltip. 
    
    Also, @garrensmith just added https://github.com/apache/couchdb-fauxton/commit/02a5ee3f0067432d3abf4fd683397ed6d66137ab,
so we can render/remove the react components from the routes file.  I also changed my Active
Tasks PR to reflect this change, and I'll wait for Garren's feedback before I merge it in,
but something to keep in mind while your making changes. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message