couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Active tasks in React
Date Wed, 08 Apr 2015 14:46:07 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/317#discussion_r27976201
  
    --- Diff: app/addons/activetasks/components.react.jsx ---
    @@ -0,0 +1,610 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +define([
    +  'app',
    +  'api',
    +  'react',
    +  'addons/activetasks/stores',
    +  'addons/activetasks/resources',
    +  'addons/activetasks/actions'
    +], function (app, FauxtonAPI, React, Stores, Resources, Actions) {
    +
    +  var activeTasksStore = Stores.activeTasksStore;
    +  var ReactCSSTransitionGroup = React.addons.CSSTransitionGroup;
    +
    +  var ActiveTasksController = React.createClass({
    +
    +    getStoreState: function () {
    +      return {
    +        collection: activeTasksStore.getCollection(),
    +        searchTerm: activeTasksStore.getSearchTerm(),
    +        selectedRadio: activeTasksStore.getSelectedRadio(),
    +
    +        sortByHeader: activeTasksStore.getSortByHeader(),
    +        headerIsAscending: activeTasksStore.getHeaderIsAscending(),
    +
    +        setPolling: activeTasksStore.setPolling,
    +        clearPolling: activeTasksStore.clearPolling,
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    componentDidMount: function () {
    +      this.state.setPolling();
    +      activeTasksStore.on('change', this.onChange, this);
    +    },
    +
    +    componentWillUnmount: function () {
    +      this.state.clearPolling();
    +      activeTasksStore.off('change', this.onChange, this);
    +    },
    +
    +    onChange: function () {
    +      this.setState(this.getStoreState());
    +    },
    +
    +    setNewSearchTerm: function (searchTerm) {
    +      Actions.setSearchTerm(searchTerm);
    +    },
    +
    +    switchTab: function (newRadioButton) {  //radio buttons
    +      Actions.switchTab(newRadioButton);
    +    },
    +
    +    tableHeaderOnClick: function (headerClicked) {
    +      Actions.sortByColumnHeader(headerClicked);
    +    },
    +
    +    render: function () {
    +      var collection = this.state.collection;
    +      var searchTerm = this.state.searchTerm;
    +      var selectedRadio = this.state.selectedRadio;
    +      var sortByHeader = this.state.sortByHeader;
    +      var headerIsAscending = this.state.headerIsAscending;
    +
    +      var setSearchTerm = this.setNewSearchTerm;
    +      var onTableHeaderClick = this.tableHeaderOnClick;
    --- End diff --
    
    Its a good point @robertkowalski but lets leave as is for now. Passing down 4 levels is
a bit of a pain but it then allows us to keep all actions centralised to one controller component.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message