couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Nightwatch test updates
Date Tue, 07 Apr 2015 20:15:42 GMT
Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/363#discussion_r27915486
  
    --- Diff: app/addons/documents/tests/nightwatch/viewCreate.js ---
    @@ -64,20 +66,25 @@ var tests = {
             editor.getSession().setValue("function (doc) { emit(\'enteente\', 1); }");\
           ')
           .execute('$(".save")[0].scrollIntoView();')
    -      .clickWhenVisible('button.btn-success.save')
    -      .waitForElementPresent('.prettyprint', waitTime, false)
    +      .click('button.btn-success.save')
    +      .waitForAttribute('#global-notifications', 'textContent', function (notification)
{
    +        return (/View Saved./).test(notification.trim());
    +      })
    +      //go back to all docs
           .url(baseUrl + '/#/database/' + newDatabaseName + '/_all_docs')
    -      .clickWhenVisible('[data-target="#testdesigndoc"]')
    +      .waitForElementPresent('[data-target="#testdesigndoc"]', waitTime, false)
    +      .click('[data-target="#testdesigndoc"]')
    --- End diff --
    
    Nice, you're quite right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message