Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: benkeen <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-317-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-317-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: Active tasks in React
Content-Type: text/plain
Message-Id: <20150330215129.78218E1081@git1-us-west.apache.org>
Date: Mon, 30 Mar 2015 21:51:29 +0000 (UTC)

Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/317#discussion_r27435599
  
    --- Diff: app/addons/activetasks/components.react.jsx ---
    @@ -0,0 +1,589 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +define([
    +  'app',
    +  'api',
    +  'react',
    +  'addons/activetasks/stores',
    +  'addons/activetasks/resources',
    +  'addons/activetasks/actions'
    +], function (app, FauxtonAPI, React, Stores, Resources, Actions) {
    +
    +  var activeTasksStore = Stores.activeTasksStore;
    +  var ReactCSSTransitionGroup = React.addons.CSSTransitionGroup;
    +
    +  var ActiveTasksController = React.createClass({
    +
    +    getStoreState: function () {
    +      return {
    +        collection: activeTasksStore.getCollection(),
    +        searchTerm: activeTasksStore.getSearchTerm(),
    +        selectedRadio: activeTasksStore.getSelectedRadio(),
    +
    +        sortByHeader: activeTasksStore.getSortByHeader(),
    +        headerIsAscending: activeTasksStore.getHeaderIsAscending(),
    +
    +        setPolling: activeTasksStore.setPolling,
    +        clearPolling: activeTasksStore.clearPolling,
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    componentDidMount: function () {
    +      this.state.setPolling();
    +      activeTasksStore.on('change', this.onChange, this);
    +    },
    +
    +    componentWillUnmount: function () {
    +      this.state.clearPolling();
    +      activeTasksStore.off('change', this.onChange, this);
    +    },
    +
    +    onChange: function () {
    +      this.setState(this.getStoreState());
    +    },
    +
    +    setNewSearchTerm: function (e) {
    +      Actions.setSearchTerm(e.target.value);
    +    },
    +
    +    //radio buttons
    +    switchTab: function (e) {
    +      var newRadioButton = e.target.value;
    +      Actions.switchTab(newRadioButton);
    +    },
    +
    +    tableHeaderOnClick: function (e) {
    +      var headerClicked = e.target.value;
    +      Actions.sortByColumnHeader(headerClicked);
    +    },
    +
    +    render: function () {
    +      var collection = this.state.collection;
    +      var searchTerm = this.state.searchTerm;
    +      var selectedRadio = this.state.selectedRadio;
    +      var sortByHeader = this.state.sortByHeader;
    +      var headerIsAscending = this.state.headerIsAscending;
    +
    +      var setSearchTerm = this.setNewSearchTerm;
    +      var onTableHeaderClick = this.tableHeaderOnClick;
    +
    +      if (collection.length === 0 ) {
    +        return (<div className="active-tasks"><tr><td><p>  No active tasks. </p></td></tr></div>);
    +      } else {
    +        return (
    +          <div className="scrollable">
    +            <div className="inner">
    +              <ActiveTasksFilter 
    +                searchTerm={searchTerm} 
    +                selectedRadio={selectedRadio} 
    +                onSearch={setSearchTerm} 
    +                onRadioClick={this.switchTab}/>
    +              <ActiveTaskTable 
    +                collection={collection} 
    +                searchTerm={searchTerm} 
    +                selectedRadio={selectedRadio}
    +                onTableHeaderClick={onTableHeaderClick}
    +                sortByHeader={sortByHeader}
    +                headerIsAscending={headerIsAscending} />
    +            </div>
    +          </div>
    +        );
    +      }
    +    }
    +  });
    +
    +  var ActiveTasksFilter = React.createClass({
    +    getStoreState: function () {
    +      return {
    +        isFilterTrayVisible: false
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    toggleFilterTray: function () {
    +      this.setState({
    +        isFilterTrayVisible : !this.state.isFilterTrayVisible
    +      });
    +    },
    +
    +    render: function () {
    +      var filterTray = '';
    +
    +      if (this.state.isFilterTrayVisible) {
    +        filterTray = <ActiveTasksFilterTray 
    +                        key="filter-tray" 
    +                        selectedRadio={this.props.selectedRadio}
    +                        onSearch={this.props.onSearch} 
    +                        onRadioClick={this.props.onRadioClick} />;
    +      }
    +
    +      return (
    +        <div id="dashboard-upper-content">
    +          <div className="dashboard-upper-menu active-tasks">
    +            <ActiveTasksFilterTab onClick={this.toggleFilterTray} />
    +          </div>
    +          <ReactCSSTransitionGroup 
    +            className="dashboard-lower-menu" 
    +            transitionName="toggleFilterTray" 
    +            component="div" >
    +            {filterTray}
    +          </ReactCSSTransitionGroup>
    +        </div>
    +      );
    +    }
    +  });
    +
    +  var ActiveTasksFilterTab = React.createClass({
    +    render: function () {
    +      return (
    +        <ul className="nav nav-tabs" id="db-views-tabs-nav">
    +          <li>
    +            <a id="toggle-filter-tab"
    +               className="toggle-filter-tab"
    +               data-bypass="true" 
    +               data-toggle="button"
    +               onClick={this.props.onClick}>
    +              <i className="fonticon fonticon-plus"></i>
    +              Filter
    +            </a>
    +          </li>
    +        </ul>);
    +    }
    +  });
    +
    +  var ActiveTasksFilterTray = React.createClass({
    +    render: function () {
    +      return (
    +        <div className="filter-tray">
    +          <ActiveTasksFilterTrayCheckBoxes 
    +            onRadioClick={this.props.onRadioClick} 
    +            selectedRadio={this.props.selectedRadio} />
    +          <input  
    +            className="searchbox" 
    +            type="text" 
    +            name="search" 
    +            placeholder="Search for databases..." 
    +            value={this.props.searchTerm}
    +            onChange={this.props.onSearch} />  
    +        </div>
    +      );
    +    }
    +  });
    +
    +  var ActiveTasksFilterTrayCheckBoxes = React.createClass({
    +
    +    radioNames : [
    +      'All Tasks',
    +      'Replication',
    +      'Database Compaction',
    +      'Indexer',
    +      'View Compaction'
    +    ],
    +
    +    checked: function (radioName) {
    +      return this.props.selectedRadio == radioName;
    +    },
    +
    +    createCheckboxes: function () {
    +      var onRadioClick = this.props.onRadioClick;
    +      return (
    +        this.radioNames.map(function (radioName) {
    +          var checked = this.checked(radioName);
    +          var radioClassName = "radio-" + radioName.replace(' ', '-');
    +          return (
    +            <li className="active-tasks-one-checkbox" key={radioName+"li"}>
    +              <input
    +                  id={radioName.replace(' ', '-')}
    +                  type="radio"
    +                  key ={radioName} 
    +                  name="radio-button-active-task-filter-tray" 
    +                  value={radioName}
    +                  checked={checked}
    +                  onChange={onRadioClick} />
    +              <label htmlFor={radioName} className="active-tasks-checkbox-label">
    +              {radioName}
    +              </label>
    +            </li>
    +          );
    +        }.bind(this))
    +      );
    +    },
    +
    +    render: function () {
    +      var filterCheckboxes = this.createCheckboxes();
    +      return (
    +        <ul className="filter-checkboxes">
    +          <form className="filter-checkboxes-form">
    +          {filterCheckboxes}
    +          </form>
    +        </ul>
    +      );
    +    }
    +  });
    +
    +  var ActiveTaskTable = React.createClass({
    +    render: function () {
    +      var collection = this.props.collection;
    +      var selectedRadio = this.props.selectedRadio;
    +      var searchTerm = this.props.searchTerm;
    +      var sortByHeader = this.props.sortByHeader;
    +      var onTableHeaderClick = this.props.onTableHeaderClick;
    +      var headerIsAscending = this.props.headerIsAscending;
    +
    +      return (
    +        <div id="dashboard-lower-content">
    +          <table className="table table-bordered table-striped active-tasks">
    +            <ActiveTasksTableHeader 
    +              onTableHeaderClick={onTableHeaderClick}
    +              sortByHeader={sortByHeader}
    +              headerIsAscending={headerIsAscending}/>
    +            <ActiveTasksTableBody 
    +              collection={collection} 
    +              selectedRadio={selectedRadio} 
    +              searchTerm={searchTerm}/>
    +          </table>
    +        </div>
    +      );
    +    }
    +  });
    +
    +  var ActiveTasksTableHeader = React.createClass({
    +    headerNames : [
    +      ['type', 'Type'],
    +      ['database', 'Database'],
    +      ['started_on', 'Started On'],
    +      ['updated_on', 'Updated On'],
    +      ['pid', 'PID'],
    +      ['progress', 'Status']
    +    ],
    +
    +    createTableHeadingFields: function () {
    +      var onTableHeaderClick = this.props.onTableHeaderClick;
    +      var sortByHeader = this.props.sortByHeader;
    +      var headerIsAscending = this.props.headerIsAscending;
    +      return (
    +        this.headerNames.map(function (header) {
    +          return (
    +            <TableHeader 
    +              HeaderName={header[0]}
    +              DisplayName={header[1]}
    +              key={header[0]}
    +              onTableHeaderClick={onTableHeaderClick}
    +              sortByHeader={sortByHeader}
    +              headerIsAscending={headerIsAscending} />
    +          );
    +        })
    +      );
    +    },
    +
    +    render: function () {
    +      var tableHeadingFields = this.createTableHeadingFields();
    +      return (
    +        <thead>
    +          <tr>{tableHeadingFields}</tr>
    +        </thead>
    +      );
    +    }
    +  });
    +
    +  var TableHeader = React.createClass({
    +    arrow: function () {
    +      var sortBy = this.props.sortByHeader;
    +      var currentName = this.props.HeaderName;
    +      var headerIsAscending = this.props.headerIsAscending;
    +      var arrow = headerIsAscending ? 'icon icon-caret-up' : 'icon icon-caret-down';
    +
    +      if (sortBy === currentName) {
    +        return <i className={arrow}></i>;
    +      }
    +    },
    +
    +    render: function () {
    +      var arrow = this.arrow();
    +      var th_class = 'header-field ' + this.props.HeaderName;
    +
    +      return (
    +        <input
    +          type="radio"
    +          name="header-field"
    +          id={this.props.HeaderName}
    +          value={this.props.HeaderName}
    +          className="header-field radio"
    +          onChange={this.props.onTableHeaderClick}>
    +          <th className={th_class} value={this.props.HeaderName}>
    +            <label 
    +              className="header-field label-text"
    +              htmlFor={this.props.HeaderName}>
    +              {this.props.DisplayName} {arrow}
    +            </label>
    +          </th>
    +        </input>
    +      );
    +    }
    +  });
    +
    +  var ActiveTasksTableBody = React.createClass({
    +
    +    getStoreState: function () {
    +      return {
    +        filteredTable: activeTasksStore.getFilteredTable(this.props.collection)
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    componentWillReceiveProps: function (nextProps) {
    +      this.setState({
    +        filteredTable:
    +          activeTasksStore.getFilteredTable(this.props.collection)
    +      });
    +    },
    +
    +    createRows: function () {
    +      var isThereASearchTerm = this.props.searchTerm.trim() === "";
    +
    +      if (this.state.filteredTable.length === 0) {
    +        return isThereASearchTerm ? this.noActiveTasks() : this.noActiveTasksMatchFilter();
    +      }
    +
    +      return _.map(this.state.filteredTable, function (item, iteration) {
    +        return <ActiveTaskTableBodyContents key={Math.random()} item={item} />;
    +      });
    +    },
    +
    +    noActiveTasks: function () {
    +      return (
    +        <tr className="no-matching-database-on-search">
    +          <td  colSpan="6">No active {this.props.selectedRadio} tasks.</td>
    +        </tr>
    +      );
    +    },
    +
    +    noActiveTasksMatchFilter: function () {
    +      return (
    +        <tr className="no-matching-database-on-search">
    +          <td colSpan="6">No active {this.props.selectedRadio} tasks match with filter: "{this.props.searchTerm}".</td>
    +        </tr>
    +      );
    +    },
    +
    +    render: function () {
    +      var tableBody = this.createRows();
    +      return (
    +        <tbody className="js-tasks-go-here">
    +        {tableBody}
    +        </tbody>
    +      );
    +    }
    +  });
    +
    +  var ActiveTaskTableBodyContents = React.createClass({
    +    getInfo: function (item) {
    +      return {
    +        type : item.type,
    +        objectField: activeTasksHelpers.getDatabaseFieldMessage(item) ,
    +        started_on: activeTasksHelpers.getTimeInfo(item.started_on),
    +        updated_on: activeTasksHelpers.getTimeInfo(item.updated_on),
    +        pid: item.pid.replace(/[<>]/g, ''),
    +        progress: activeTasksHelpers.getProgressMessage(item),
    +      };
    +    },
    +
    +    multilineMessage: function (messageArray, optionalClassName) {
    +
    +      if (!optionalClassName) {
    +        optionalClassName = '';
    +      }
    +      var cssClasses = 'multiline-active-tasks-message ' + optionalClassName;
    +
    +      return messageArray.map(function (msgLine, iterator) {
    +        return <p key={iterator} className={cssClasses}>{msgLine}</p>;
    +      });
    +    },
    +
    +    render: function () {
    +      var rowData =  this.getInfo(this.props.item);
    +      var objectFieldMsg = this.multilineMessage(rowData.objectField);
    +      var startedOnMsg = this.multilineMessage(rowData.started_on, 'time');
    +      var updatedOnMsg = this.multilineMessage(rowData.updated_on, 'time');
    +      var progressMsg = this.multilineMessage(rowData.progress);
    +
    +      return (
    +        <tr>
    +          <td>{rowData.type}</td>
    +          <td>{objectFieldMsg}</td>
    +          <td>{startedOnMsg}</td>
    +          <td>{updatedOnMsg}</td>
    +          <td>{rowData.pid}</td>
    +          <td>{progressMsg}</td>
    +        </tr>
    +      );
    +    }
    +  });
    +
    +  var ActiveTasksPollingWidget = React.createClass({
    +
    +    getStoreState: function () {
    +      return {
    +        pollingInterval:  activeTasksStore.getPollingInterval()
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    componentDidMount: function () {
    +      activeTasksStore.on('change', this.onChange, this);
    +    },
    +
    +    onChange: function () {
    +      if (this.isMounted()) {
    +        this.setState(this.getStoreState());
    +      }
    +    },
    +
    +    pollingIntervalChange: function (event) {
    +      Actions.changePollingInterval(event.target.value);
    +    },
    +
    +    getPluralForLabel: function () {
    +      return this.state.pollingInterval === "1" ? '' : 's';
    +    },
    +
    +    createPollingWidget: function () {
    +      var pollingInterval = this.state.pollingInterval;
    +      var s = this.getPluralForLabel();
    +      var onChangeHandle = this.pollingIntervalChange;
    +
    +      return (
    +        <ul className="polling-interval-widget">
    +          <li className="polling-interval-name">Polling interval
    +            <label className="polling-interval-time-label" htmlFor="pollingRange"> 
    +              <span>{pollingInterval}</span> second{s} 
    +            </label>
    +          </li>
    +          <li>
    +            <input 
    +              id="pollingRange" 
    +              type="range" 
    +              min="1" 
    +              max="30" 
    +              step="1" 
    +              value={pollingInterval} 
    +              onChange={onChangeHandle}/>
    +          </li>
    +        </ul>
    +      );
    +    },
    +
    +    render: function () {
    +      var pollingWidget = this.createPollingWidget();
    +
    +      return  <div>{pollingWidget}</div>;
    +    }
    +  });
    +
    +  var activeTasksHelpers = {
    +    getTimeInfo: function (timeStamp) {
    +      var timeMessage = [app.helpers.formatDate(timeStamp)];
    +      timeMessage.push(app.helpers.getDateFromNow(timeStamp));
    +      return timeMessage;
    +    },
    +
    +    getDatabaseFieldMessage: function (item) {
    +      var type = item.type;
    +      var databaseFieldMessage = [];
    +
    +      if (type === 'replication') {
    +        databaseFieldMessage.push('From: ' + item.source);
    +        databaseFieldMessage.push('To: ' + item.target);
    +      } else if (type === 'indexer') {
    +        databaseFieldMessage.push(item.database);
    +        databaseFieldMessage.push('(View: ' + item.design_document + ')');
    +      } else {
    +        databaseFieldMessage.push(item.database);
    +      }
    +
    +      return databaseFieldMessage;
    +    },
    +
    +    getProgressMessage: function (item) {
    +      var progressMessage = [];
    +      var type = item.type;
    +
    +      if (item.hasOwnProperty('progress')) {
    +        progressMessage.push('Progress: ' + item.progress + '%');
    +      }
    +
    +      if (type === 'indexer') {
    +        progressMessage.push(
    +          'Processed ' + item.changes_done + ' of ' + item.total_changes + ' changes.'
    +        );
    +      } else if (type === 'replication') {
    +        progressMessage.push(item.docs_written + ' docs written.');
    +
    +        if (item.hasOwnProperty('changes_pending')) {
    +          progressMessage.push(item.changes_pending + ' pending changes.');
    +        }
    +      }
    +
    +      if (item.hasOwnProperty('source_seq')) {
    +        progressMessage.push('Current source sequence: ' + item.source_seq + '. ');
    +      }
    +
    +      if (item.hasOwnProperty('changes_done')) {
    +        progressMessage.push(item.changes_done + ' Changes done.');
    +      }
    +
    +      return progressMessage;
    +    }
    +  };
    +
    +  return {
    +    renderActiveTasks: function (el) {
    +      React.render(<ActiveTasksController />, el);
    +    },
    +
    +    removeActiveTasks: function (el) {
    --- End diff --
    
    Seems like we do this a lot - i.e. a custom function to remove a React element at a DOM node. Wonder if we should just add a generic `remove()` method in the main Fauxton React components section that removes an element at a node...?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---