couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andy Wenk <andyw...@apache.org>
Subject Re: Closing old PRs
Date Tue, 24 Mar 2015 09:19:59 GMT
just out of curiosity Alex, what exactly in this string will close the
ticket:

"This closes #42"

All the words? Or just #42 ?

Thanks ;-)



On 24 March 2015 at 09:04, Alexander Shorin <kxepal@gmail.com> wrote:

> There are the following ways to automatically close PRs:
> 1. Add "This closes #42" to commit message
> 2. Explicit merge of PR'ed branch
> 3. When sha's of commits on master equals sha's PR commits (e.g. merge
> via rebase)
>
> In any other cases we need to ask an author to close his PR manually.
> --
> ,,,^..^,,,
>
>
> On Tue, Mar 24, 2015 at 10:35 AM, Andy Wenk <andy@nms.de> wrote:
> > Although it is a lot of work to go through all the PRs one way is to ask
> > the submitter to close the PR. If not done after say a week, simply close
> > it. Not sure if this can be done without this #magic at github ...
> > On Mar 24, 2015 1:14 AM, "Paul Davis" <paul.joseph.davis@gmail.com>
> wrote:
> >
> >> Hi all,
> >>
> >> I've been going through trying to review open PRs today (long overdue, I
> >> know) and I've noticed that there seem to be a lot of "open" PRs that
> have
> >> actually been merged. Did we ever find a way to be able to close PRs
> >> wihtout having to add a commit with the "Fixes #whatever" magic?
> >>
> >> Paul
> >>
>



-- 
Andy Wenk
Hamburg - Germany
RockIt!

GPG fingerprint: C044 8322 9E12 1483 4FEC 9452 B65D 6BE3 9ED3 9588

 https://people.apache.org/keys/committer/andywenk.asc

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message