couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davisp <...@git.apache.org>
Subject [GitHub] couchdb pull request: Add systemd notification support
Date Mon, 23 Mar 2015 23:51:50 GMT
Github user davisp commented on the pull request:

    https://github.com/apache/couchdb/pull/258#issuecomment-85250241
  
    This seems like it'd be better to write this as a plugin.
    
    For starters, randomly loading a module named sd_notify seems not good from a security
point of view for anyone that's not aware of it. Second, as @rnewson states, this is a bit
specific to a daemon manager and as such seems a bit of a difficult sell in terms of feature
creep. Thirdly, this will be a bit of a lie when we get to clustered nodes since couch_server
doesn't directly define when the node is "alive".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message