couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janl <...@git.apache.org>
Subject [GitHub] couchdb-chttpd pull request: add _changes?feed=stream sugar for co...
Date Thu, 19 Mar 2015 19:53:59 GMT
Github user janl commented on a diff in the pull request:

    https://github.com/apache/couchdb-chttpd/pull/28#discussion_r26791206
  
    --- Diff: src/chttpd_db.erl ---
    @@ -93,7 +93,7 @@ handle_changes_req1(#httpd{}=Req, Db) ->
                 couch_stats:decrement_counter([couchdb, httpd, clients_requesting_changes])
             end;
         _ ->
    -        Msg = <<"Supported `feed` types: normal, continuous, longpoll, eventsource">>,
    +        Msg = <<"Supported `feed` types: normal, continuous/stream, longpoll, eventsource">>,
    --- End diff --
    
    a bit of clarification, I most care about the error message being clear and I suggest
we use @kxepal’s version, if we add the alias. I don’t advocate for or against the alias,
but if others think, that it is a good idea, you should go ahead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message