couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Fix Views toggle with dot symbol in ...
Date Tue, 17 Mar 2015 12:52:52 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/319#discussion_r26569230
  
    --- Diff: app/addons/documents/shared-views.js ---
    @@ -160,12 +160,20 @@ function(app, FauxtonAPI, Components, Documents, Databases) {
         className:  "nav nav-list",
         template: "addons/documents/templates/design_doc_menu",
         events: {
    -      "click .js-collapse-toggle": "toggleArrow"
    +      "click .js-collapse-toggle": "toggleArrow",
    +      "click .js-toggle-submenu": 'toggleSubmenu'
         },
     
         toggleArrow:  function(e){
           this.$(e.currentTarget).toggleClass("down");
    +      $('#' + this.model.id.replace(/^_design\//,"").replace(/\./g, '\\.')).collapse('toggle');

    +      //if there is a '.' in the design doc name, jquery interprets that as a class
    +      //see assets/js/libs/bootstrap.js line 1739
         },
    +    toggleSubmenu: function (e) {
    +      this.$(e.currentTarget).toggleClass("down");
    +    },
    +
    --- End diff --
    
    please follow the codingguidelines:
    
    newline between properties,
    single quotes,
    space after comma


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message