couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <>
Subject [GitHub] couchdb-fauxton pull request: Changes page content moved to React
Date Wed, 04 Mar 2015 21:53:58 GMT
Github user benkeen commented on the pull request:
    Thanks for the feedback, guys. Very helpful! I've updated the code as per your feedback.
    @garrensmith, I tried combining the elements into a single ChangesPageController element
- turned out that part was very straightforward, even with a generic `TabbedPage` component
that allowed you passing the header + body react components. But the single React element
caused lots of problems with the different pages being handled by the route object. Some of
them do view.remove() on the header but not the main body content when navigating around,
which proved very difficult when the whole page was a single React component. After a lot
of experimenting I decided it may be a little too soon for that refactor. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message