couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: add test for _changes?feed=stream
Date Sun, 01 Mar 2015 16:22:11 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/307#discussion_r25568562
  
    --- Diff: test/javascript/tests/changes.js ---
    @@ -17,131 +17,140 @@ function jsonp(obj) {
     }
     
     couchTests.changes = function(debug) {
    -  var db = new CouchDB("test_suite_db", {"X-Couch-Full-Commit":"true"});
    -  db.deleteDb();
    -  db.createDb();
    +  var db;
       if (debug) debugger;
     
    -  var req = CouchDB.request("GET", "/test_suite_db/_changes");
    -  var resp = JSON.parse(req.responseText);
    +  // poor man's browser detection
    --- End diff --
    
    good to know, i can remove it, it is part of the older code that i moved into a function
to make it reusable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message