Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BFEE1792E for ; Wed, 4 Feb 2015 15:50:39 +0000 (UTC) Received: (qmail 85137 invoked by uid 500); 4 Feb 2015 15:50:37 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 84989 invoked by uid 500); 4 Feb 2015 15:50:37 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 84832 invoked by uid 99); 4 Feb 2015 15:50:37 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Feb 2015 15:50:37 +0000 Date: Wed, 4 Feb 2015 15:50:37 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@couchdb.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (COUCHDB-2561) Make config API consistent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COUCHDB-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305317#comment-14305317 ] ASF subversion and git services commented on COUCHDB-2561: ---------------------------------------------------------- Commit 4b102bf7de3b835cf82c81276deb3e4afbd942d9 in couchdb-chttpd's branch refs/heads/master from [~iilyak] [ https://git-wip-us.apache.org/repos/asf?p=couchdb-chttpd.git;h=4b102bf ] Update config_listener behaviuor COUCHDB-2561 > Make config API consistent > -------------------------- > > Key: COUCHDB-2561 > URL: https://issues.apache.org/jira/browse/COUCHDB-2561 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Database Core > Reporter: ILYA > Assignee: ILYA > > There are 2 problems with API which need to be fixed. > 1) Mix of message driven and callback driven > API for config_listener is hard to use. > In particular there is a gen_event_EXIT > message which is sent to the process which called config:listen_for_changes. > This makes API unsuitable for use in the context of a supervisor. Since supervisors do not support handling of arbitrary messages. This message also causing problems for test suite. > This message could be substituted with > a call to Module:handle_config_stop(Pid, Reason, State). > 2) Since for section, key, value we only support lists but not arbitrary terms. More strick guards are needed to make sure the caller of the API fails with badarg -- This message was sent by Atlassian JIRA (v6.3.4#6332)