Return-Path: 
 <dev-return-41661-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org>
X-Original-To: apmail-couchdb-dev-archive@www.apache.org
Delivered-To: apmail-couchdb-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B840110A8B
	for <apmail-couchdb-dev-archive@www.apache.org>;
 Fri, 13 Feb 2015 10:39:38 +0000 (UTC)
Received: (qmail 46328 invoked by uid 500); 13 Feb 2015 10:39:33 -0000
Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org
Received: (qmail 46263 invoked by uid 500); 13 Feb 2015 10:39:33 -0000
Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@couchdb.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@couchdb.apache.org>
List-Post: <mailto:dev@couchdb.apache.org>
List-Id: <dev.couchdb.apache.org>
Reply-To: dev@couchdb.apache.org
Delivered-To: mailing list dev@couchdb.apache.org
Received: (qmail 46252 invoked by uid 99); 13 Feb 2015 10:39:33 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Feb 2015 10:39:33 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 0738EE028F; Fri, 13 Feb 2015 10:39:32 +0000 (UTC)
From: robertkowalski <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-265-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-265-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: Changes page Filters tab moved
 to Re...
Content-Type: text/plain
Message-Id: <20150213103933.0738EE028F@git1-us-west.apache.org>
Date: Fri, 13 Feb 2015 10:39:32 +0000 (UTC)

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24656033
  
    --- Diff: app/addons/documents/changes/changes-header.react.jsx ---
    @@ -0,0 +1,236 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +define([
    +  'react',
    +  'addons/documents/changes/actions',
    +  'addons/documents/changes/stores'
    +], function (React, Actions, Stores) {
    +
    +  var changesFilterStore = Stores.changesFilterStore;
    +  var ReactCSSTransitionGroup = React.addons.CSSTransitionGroup;
    +
    +
    +  var ChangesHeader = React.createClass({
    +    getInitialState: function () {
    +      return {
    +        showTabContent: changesFilterStore.isTabVisible()
    +      };
    +    },
    +
    +    componentDidMount: function () {
    +      changesFilterStore.on('change', this.onChange, this);
    +    },
    +
    +    onChange: function () {
    +      this.setState({
    +        showTabContent: changesFilterStore.isTabVisible()
    +      });
    +    },
    +
    +    toggleFilterSection: function () {
    +      Actions.toggleTabVisibility();
    +    },
    +
    +    render: function () {
    +      var tabContent = '';
    +
    +      if (this.state.showTabContent) {
    +        tabContent = <ChangesHeaderTabContent key="changesFilterSection" />;
    +      }
    +
    +      return (
    +        <div className="changes-header-section">
    +          <ChangesHeaderTab onToggle={this.toggleFilterSection} />
    +          <ReactCSSTransitionGroup transitionName="toggleChangesFilter" component="div" className="changes-tab-content">
    +            {tabContent}
    +          </ReactCSSTransitionGroup>
    +        </div>
    +      );
    +    }
    +  });
    +
    +  var ChangesHeaderTab = React.createClass({
    +    propTypes: {
    +      onToggle: React.PropTypes.func.isRequired
    +    },
    +
    +    render: function () {
    +      return (
    +        <div className="dashboard-upper-menu">
    +          <ul className="nav nav-tabs" id="db-views-tabs-nav">
    +            <li>
    +              <a href="#filter" onClick={this.props.onToggle} data-bypass="true" data-toggle="tab">
    +                <i className="fonticon fonticon-plus"></i> Filter
    +              </a>
    +            </li>
    +          </ul>
    +        </div>
    +      );
    +    }
    +  });
    +
    +  var ChangesHeaderTabContent = React.createClass({
    +    render: function () {
    +      return (
    +        <div className="tab-content">
    +          <div className="tab-pane active" ref="filterTab">
    +            <div className="changes-header js-filter">
    +              <ChangesFilter />
    +            </div>
    +          </div>
    +        </div>
    +      );
    +    }
    +  });
    +
    +  var ChangesFilter = React.createClass({
    +    getStoreState: function () {
    +      return {
    +        filters: changesFilterStore.getFilters()
    +      };
    +    },
    +
    +    onChange: function () {
    +      this.setState(this.getStoreState());
    +    },
    +
    +    // props belong to the parent, so these aren't stored in the related store
    +    getDefaultProps: function () {
    +      return {
    +        addItemPlaceholder: 'Type a filter',
    +        helpText: 'e.g. debug or <1.4.1> or any regex',
    +        tooltip: ''
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    submitForm: function (e) {
    +      e.preventDefault();
    +      e.stopPropagation();
    +
    +
    +      var filter = this.refs.addItem.getDOMNode().value.trim();
    +      if (!filter) {
    +        return;
    +      }
    +
    +      Actions.addFilterViewItem(filter);
    +      this.refs.addItem.getDOMNode().value = '';
    --- End diff --
    
    You are still directly accessing the DOM from an event handler?
    
    Shouldn't we use an action connected to a store which then updates the element like this:
    
    ```
    <input type="text" ref="addItem" placeholder={this.props.addItemPlaceholder} value="{this.state.addItemValue}" />
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---