couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryan Chan <bryan.c...@ca.ibm.com>
Subject Re: [GitHub] couchdb-snappy pull request: Support big-endian builds
Date Wed, 18 Feb 2015 13:51:45 GMT

Hello CouchDB developers,

I am new to the list; please be gentle. :-)

I created a pull request on GitHub yesterday (see below) for a relatively
simple patch that would allow CouchDB to be built correctly on big-endian
platforms. What is the usual process for getting this kind of change
approved and committed?

FWIW I have also sent a pull request for the same change to the upstream
project, snappy-erlang-nif.

Thanks,

Bryan
--
Bryan Chan
bryan.chan@ca.ibm.com



bryanpkc <git@git.apache.org> wrote on 2015-02-17 01:22:02 PM:

> From: bryanpkc <git@git.apache.org>
> To: dev@couchdb.apache.org
> Date: 2015-02-17 01:22 PM
> Subject: [GitHub] couchdb-snappy pull request: Support big-endian builds
>
> GitHub user bryanpkc opened a pull request:
>
>     https://github.com/apache/couchdb-snappy/pull/2
>
>     Support big-endian builds
>
>     Google snappy's configure script defines WORDS_BIGENDIAN in
> config.h if it detects that the build machine is big-endian. rebar
> should do the same when building the C++ code for this NIF. This
> patch allows CouchDB to be built and run on big-endian Linux
> systems, e.g. ppc64, s390x, etc.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/bryanpkc/couchdb-snappy big-endian
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/couchdb-snappy/pull/2.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #2
>
> ----
> commit 6bc08a598cdd3fac17666c5226a1283cbce983db
> Author: Bryan Chan <bryanpkc@gmail.com>
> Date:   2015-02-17T14:41:27Z
>
>     Support big-endian builds
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have
your
> reply appear on GitHub as well. If your project does not have this
feature
> enabled and wishes so, or if the feature is enabled but not working,
please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message