couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-2573) Problems selecting text in Ace editor
Date Wed, 11 Feb 2015 16:43:12 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316498#comment-14316498
] 

ASF GitHub Bot commented on COUCHDB-2573:
-----------------------------------------

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/266

    Style fix for selecting text in Ace editor

    This PR contains two things:
    1. reverts an old custom change to the Ace editor theme file
    2. updates the select text style, as per: https://issues.apache.org/jira/browse/COUCHDB-2573

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2560-ace-editor-theme-update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #266
    
----
commit 1287abf9da29b965338a6559f7769e71ec3b3666
Author: Ben Keen <ben.keen@gmail.com>
Date:   2015-02-11T16:31:47Z

    Revert "Style fix for clicking on doc line nums"
    
    This reverts commit b53a4db5a4d48320da28fd0f9dd173cb94c67f5b.

commit 3f51e122a8730e615bed23b69ebb94d8ceb10557
Author: Ben Keen <ben.keen@gmail.com>
Date:   2015-02-11T16:40:24Z

    Style fix for selected text in Ace editor
    
    This updates the background color and the location of the selected
    text bg color.
    
    Closes COUCHDB-2573

----


> Problems selecting text in Ace editor 
> --------------------------------------
>
>                 Key: COUCHDB-2573
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2573
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Ben Keen
>            Assignee: Ben Keen
>
> Two issues:
> 1. The background color isn't that different from the selected row colour, so it's not
clear what's selected.
> 2. The selected text background looks like it's being shifted to the left, rather than
behind the actual text you're selecting



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message