couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb-couch pull request: 2547 fix broken tests
Date Wed, 18 Feb 2015 17:29:35 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/35#discussion_r24920915
  
    --- Diff: include/couch_eunit.hrl ---
    @@ -31,6 +31,11 @@
         filename:join([?BUILDDIR(), "src", "couch", "test", "fixtures"])).
     -define(TEMPDIR,
         filename:join([?BUILDDIR(), "tmp", "tmp_data"])).
    +-define(ABS_PATH(File),
    +    filename:join([
    +        filename:dirname(
    +            filename:dirname(
    +                filename:dirname(filename:absname(File)))), File])).
    --- End diff --
    
    I lost myself here counting what the actual path here will be. Is there way to make it
better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message