couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Fix missing confirmation when leavin...
Date Thu, 12 Feb 2015 18:46:59 GMT
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/267#issuecomment-74127677
  
    Awesome. +1 
    
    I still think https://github.com/apache/couchdb-fauxton/pull/263 should be added, because
the currently logic is incorrect: it just checks for the *existence* of the data-bypass attribute
and not its value (true/false). As such, it will never run the event delegated code (FauxtonAPI.navigate())
for anything with that attribute regardless of value. 
    
    Your fix fixes it for React components, but not for any old code. 
    
    Just my 2 cents.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message