couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Changes page Filters tab moved to Re...
Date Thu, 12 Feb 2015 00:24:31 GMT
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-73994457
  
    @benkeen this looks a lot better, we will need tests to merge this, examples:
    
    - `ChangesHeader `: the element shows/removes the subcomponent conditionally if the state
changes / actions are fired
    
    - test what happens on `onToggle={this.toggleFilterSection}`
    
    - are filters really removed after clicking on the remove button



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message