Return-Path: 
 <dev-return-40826-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org>
X-Original-To: apmail-couchdb-dev-archive@www.apache.org
Delivered-To: apmail-couchdb-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1ECC617A1D
	for <apmail-couchdb-dev-archive@www.apache.org>;
 Tue, 13 Jan 2015 08:35:24 +0000 (UTC)
Received: (qmail 14903 invoked by uid 500); 13 Jan 2015 08:35:25 -0000
Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org
Received: (qmail 14842 invoked by uid 500); 13 Jan 2015 08:35:25 -0000
Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@couchdb.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@couchdb.apache.org>
List-Post: <mailto:dev@couchdb.apache.org>
List-Id: <dev.couchdb.apache.org>
Reply-To: dev@couchdb.apache.org
Delivered-To: mailing list dev@couchdb.apache.org
Received: (qmail 14831 invoked by uid 99); 13 Jan 2015 08:35:24 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 08:35:24 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 8F00092D0A8; Tue, 13 Jan 2015 08:35:24 +0000 (UTC)
From: garrensmith <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-216-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-216-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: Adding React into Fauxton
Content-Type: text/plain
Message-Id: <20150113083524.8F00092D0A8@tyr.zones.apache.org>
Date: Tue, 13 Jan 2015 08:35:24 +0000 (UTC)

Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22848698
  
    --- Diff: app/addons/fauxton/components.react.jsx ---
    @@ -0,0 +1,170 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +define([
    +  "api",
    +  "react",
    +  "addons/fauxton/stores",
    +  "addons/fauxton/actions"
    +],
    +
    +function(FauxtonAPI, React, Stores, Actions) {
    +  var navBarStore = Stores.navBarStore;
    +
    +  var Footer = React.createClass({
    +    getStoreState: function () {
    +      return {
    +        version: navBarStore.getVersion()
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    onChange: function () {
    +      this.setState(this.getStoreState());
    +    },
    +
    +    componentDidMount: function () {
    +      navBarStore.on('change', this.onChange, this);
    +    },
    +
    +    componentWillUnmount: function() {
    +      navBarStore.off('change', this.onChange);
    +    },
    +
    +    render: function () {
    +      var version = this.state.version;
    +
    +      if (!version) { return null; }
    +      return (
    +        <div className="version-footer">
    +          Fauxton on 
    +          <a href="http://couchdb.apache.org/">Apache CouchDB</a>
    +          <br/> 
    +          v. {version}
    +        </div>
    +      );
    +    }
    +  });
    +
    +  var Burger = React.createClass({
    +    render: function () {
    +      return (
    +        <div className="burger" onClick={this.toggleMenu}>
    +          <div></div>
    +          <div></div>
    +          <div></div>
    +        </div>
    +      );
    +    },
    +
    +    toggleMenu: function () {
    +      Actions.toggleNavbarMenu();
    +    }
    +  });
    +
    +  var NavLink = React.createClass({
    +    render: function () {
    +      var link = this.props.link;
    +      var liClassName = this.props.active === link.title ? 'active' : '';
    +
    +      return (
    +        <li data-nav-name={link.title} className={liClassName} >
    +          <a href={link.href}>
    +            <i className={link.icon + " fonticon "}></i>
    +            {link.title}
    +          </a>
    +        </li>
    +      );
    +    }
    +  });
    +
    +  var NavBar = React.createClass({
    +    getStoreState: function () {
    +      return {
    +        navLinks: navBarStore.getNavLinks(),
    +        bottomNavLinks: navBarStore.getBottomNavLinks(),
    +        footerNavLinks: navBarStore.getFooterNavLinks(),
    +        activeLink: navBarStore.getActiveLink()
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    createLinks: function (links) {
    +      return _.map(links, function (link, i) {
    +        return <NavLink key={i} link={link} active={this.state.activeLink} />;
    +      }, this);
    +    },
    +
    +    onChange: function () {
    +      this.setState(this.getStoreState());
    +    },
    +
    +    componentDidMount: function () {
    +      navBarStore.on('change', this.onChange, this);
    +    },
    +
    +    componentWillUnmount: function() {
    +      navBarStore.off('change', this.onChange);
    +    },
    +
    +    render: function () {
    +      var navLinks = this.createLinks(this.state.navLinks);
    +      var bottomNavLinks = this.createLinks(this.state.bottomNavLinks);
    +      var footerNavLinks = this.createLinks(this.state.footerNavLinks);
    +
    +      return (
    +        <div className="navbar">
    +          <Burger />
    +          <nav id="main_navigation">
    +            <ul id="nav-links" className="nav">
    +              {navLinks}
    +            </ul>
    +
    +            <div id="bottom-nav">
    +              <ul id="bottom-nav-links" className="nav">
    +                {bottomNavLinks}
    +              </ul>
    +            </div>
    +          </nav>
    +
    +          <div className="bottom-container">
    +            <div className="brand">
    +              <div className="icon">Apache Fauxton</div>
    +            </div>
    +            <Footer />
    +            <div id="footer-links">
    +              <ul id="footer-nav-links" className="nav">
    +                {footerNavLinks}
    +              </ul>
    +            </div>
    +          </div>
    +        </div>
    +      );
    +    }
    +  });
    +
    +
    +  return {
    --- End diff --
    
    Yes I agree. I think we should move to doing it this way going forward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---