couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: header-control-bar: fix select-all-s...
Date Wed, 28 Jan 2015 18:12:19 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/251

    header-control-bar: fix select-all-state

    When I select all documents
    And there are less documents than I have set to display per page
    Then I want the select-all-button to be selected/disabled
    
    As I checked for the setting of the page compared to the selected
    documents it can happen that if we have not enough documents to
    show on the page that the status of the select-all was wrong.
    
    Added test to avoid regressions in the future and to prove my fix

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb-fauxton fix-header-state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #251
    
----
commit 3889357cb9e88bcf428285cd843bbb5bafb20da1
Author: Robert Kowalski <robertkowalski@apache.org>
Date:   2015-01-28T18:08:53Z

    header-control-bar: fix select-all-state
    
    When I select all documents
    And there are less documents than I have set to display per page
    Then I want the select-all-button to be selected/disabled
    
    As I checked for the setting of the page compared to the selected
    documents it can happen that if we have not enough documents to
    show on the page that the status of the select-all was wrong.
    
    Added test to avoid regressions in the future and to prove my fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message