couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michellephung <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: header-control-bar: fix select-all-s...
Date Wed, 28 Jan 2015 19:06:13 GMT
Github user michellephung commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/251#issuecomment-71894768
  
    +1
    
    To test: 
    On master, if you have database with 8 documents, and show 5 documents at a time, view
the second page (doc 6-8),  and hit 'select all', notice that the 'select all' and 'unselect
all' are both grayed out.
    
    When on pr/251, this doesn't happen. 
    
    On another note: the highlight select states are a bit confusing. 
    I realize that a highlight state in the UI means that that current button is being shown,
but a greyed out button makes me think that a button is disabled, not that that it is a selectable
button.  The only thing I can think of that won't involve more colors or lot of ui changes
would be to change the color on hover. Any thoughts?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message