couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From seanbarclay <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Create Header-Control-Bar in React
Date Fri, 23 Jan 2015 20:02:19 GMT
Github user seanbarclay commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/242#issuecomment-71256102
  
    @robertkowalski really nice work touching this up. 
    
    The only thing I'm noticing is that if you have all docs deselected, then you click on
one or more docs in the list, nothing happens if you hit deselect. 
    
    Same thing goes if you have all docs in the list selected, then you deselect one and hit
select all. It doesn't re-select the one unselected doc. 
    
    Lastly, "Select All" and "Deselect All" indicator colors should only be turned on if All
or None of the docs are selected. For instance, if all docs were selected, "Select All" could
be indicated as active (red). However, if you deselect >=1 docs in the list, then it should
no longer be a true statement and therefore "Select All" should not be active, it should be
back to normal and ready to toggle back on if clicked. 
    
    Ping me if you need further help there. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message