couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Improvements to doc collapsed state
Date Thu, 22 Jan 2015 18:38:39 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/230#discussion_r23398106
  
    --- Diff: app/addons/documents/views.js ---
    @@ -453,25 +458,31 @@ function(app, FauxtonAPI, Components, Documents, Databases, Views,
QueryOptions)
           }
     
           this.toggleTrash();
    +      this.updateExpandButtonLabel();
         },
     
         serialize: function() {
           return {
             viewList: this.viewList,
    -        expandDocs: this.expandDocs,
             endOfResults: !this.pagination.canShowNextfn()
           };
         },
     
    -    collapse: function (event) {
    -      event.preventDefault();
    +    toggleExpandCollapse: function (e) {
    +      e.preventDefault();
    +      var expand = this.$(e.target).find("i").hasClass('icon-plus');
     
    -      if (this.expandDocs) {
    -        this.expandDocs = false;
    --- End diff --
    
    this will get changed back again once the headerbar in react is merged - we can't use
the dom for storing state there (which is a good thing) and depend on `this.expandDocs`
    
    is there a special reason to switch to the usage of classes? We can decide to use the
`this.expandDocs` here again or we will have to change that when one of us is having a huge
merge conflict and maybe there are reasons to use the class that would introduce a bug using
the old `this.expandDocs`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message